Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: set up with release please v4 and stub publish step #472

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

malandis
Copy link
Contributor

@malandis malandis commented Sep 26, 2024

Adds a release please job with v4.

Unlike v3, which we have in other repos, v4 requires a manifest
file for most of the options. We add that to the root of the
project. Also unlike v3, we also have to explicitly pass the release please
outputs from the release-please job to the publish job.

We have also verified setting the version in source. That happens with
the extra-files property in the manifest. The version in the main
__init__ requires a stub version so the release please regex can
substitute it.

In an upcoming PR we will fill out the publish job in on-push-to-main.

Adds a release please job with v4. Unlike v3, v4 requires a manifest
file for most of the options. We add that to the root of the
project. Unlike v3, we also have to explicitly pass the release please
outputs from the release-please job to the publish job.

We have also verified setting the version in source. That happens with
the extra-files property in the manifest. The version in the main
`__init__` requires a stub version so the release please regex can
substitute it.
@malandis malandis requested review from anitarua, cprice404 and a team September 26, 2024 23:45
@malandis malandis merged commit b2025cd into main Sep 27, 2024
10 checks passed
@malandis malandis deleted the ci/release-please branch September 27, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants